Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github work flow to deploy configs #892

Closed
wants to merge 3 commits into from
Closed

Conversation

jchua99
Copy link
Contributor

@jchua99 jchua99 commented Nov 24, 2023

Summary

Workflow set up golang, builds and verify build with ./openyurt_deployer help.
Next step to set up ssh service, keygen, copy the public key into auth key, add the the ssh-agent, restart the ssh daemon, before running the script.

Implementation Notes ⚒️

  • Briefly outline the overall technical solution. If necessary, identify talking points where the reviewer's attention should be drawn to.

External Dependencies 🍀

Breaking API Changes ⚠️

Simply specify none (N/A) if not applicable.

@jchua99 jchua99 requested a review from lrq619 November 24, 2023 06:39
@lrq619
Copy link
Collaborator

lrq619 commented Nov 27, 2023

This shouldn't be a separate PR, it should be part of #887
Also, please check the Set up SSH and run deploy step in the workflow, it actually fails but the test still gets passed. This is not expected.

@lrq619 lrq619 closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants